feat: add SFC V2 cloud provider integration (#116) #119
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| package v2 | ||
|
|
||
| // Package-internal constants — SSH defaults and internal tag keys. | ||
| const ( | ||
| defaultPort = 22 | ||
| defaultSSHUsername = "ubuntu" | ||
|
|
||
| // Internal tag keys written to every SFCompute V2 instance. These are stripped from | ||
| // v1.Instance.Tags on read so they don't surface as user-facing tags. | ||
| tagKeyCloudCredRefID = "brev-cloud-cred-ref-id" //nolint:gosec // not a secret | ||
| tagKeyRefID = "brev-ref-id" | ||
| ) | ||
|
|
||
| // Brev environment config for SFCompute V2. | ||
| // TODO: source these from environment variables rather than hardcoding them here. | ||
| const ( | ||
| // BrevProductionCapacityID is the SFCompute V2 capacity ID for Brev production instances. | ||
| BrevProductionCapacityID = "brev-production-capacity" | ||
|
|
||
| // BrevProductionImageID is the SFCompute image for Brev production instances | ||
| // (ubuntu-24.04.4-cuda-12.8, vm_images.vm_image_id). | ||
| BrevProductionImageID = "vmi_4GwEvmclFURy7ztFQjOdr" | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| package v2 | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| v1 "github.com/brevdev/cloud/v1" | ||
| ) | ||
|
|
||
| func getSFCCapabilitiesV2() v1.Capabilities { | ||
| return v1.Capabilities{ | ||
| v1.CapabilityCreateInstance, | ||
| v1.CapabilityTerminateInstance, | ||
| v1.CapabilityCreateTerminateInstance, | ||
| v1.CapabilityTags, | ||
| } | ||
| } | ||
|
|
||
| func (c *SFCClientV2) GetCapabilities(_ context.Context) (v1.Capabilities, error) { | ||
| return getSFCCapabilitiesV2(), nil | ||
| } | ||
|
|
||
| func (c *SFCCredentialV2) GetCapabilities(_ context.Context) (v1.Capabilities, error) { | ||
| return getSFCCapabilitiesV2(), nil | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| package v2 | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| v1 "github.com/brevdev/cloud/v1" | ||
| sfc "github.com/sfcompute/sfc-go" | ||
| ) | ||
|
|
||
| const CloudProviderID = "sfcompute" | ||
|
Contributor
There was a problem hiding this comment. ok if this collides with the existing cloudcred? |
||
|
|
||
| // SFCCredentialV2 holds authentication details for a Brev-managed SFCompute V2 account. | ||
| type SFCCredentialV2 struct { | ||
| RefID string | ||
| APIKey string `json:"api_key"` | ||
| } | ||
|
|
||
| var _ v1.CloudCredential = &SFCCredentialV2{} | ||
|
|
||
| func NewSFCCredentialV2(refID, apiKey string) *SFCCredentialV2 { | ||
| return &SFCCredentialV2{ | ||
| RefID: refID, | ||
| APIKey: apiKey, | ||
| } | ||
| } | ||
|
|
||
| func (c *SFCCredentialV2) GetReferenceID() string { | ||
| return c.RefID | ||
| } | ||
|
|
||
| func (c *SFCCredentialV2) GetAPIType() v1.APIType { | ||
| return v1.APITypeGlobal | ||
| } | ||
|
|
||
| func (c *SFCCredentialV2) GetCloudProviderID() v1.CloudProviderID { | ||
| return CloudProviderID | ||
| } | ||
|
|
||
| func (c *SFCCredentialV2) GetTenantID() (string, error) { | ||
| return "", nil | ||
| } | ||
|
|
||
| type SFCClientV2 struct { | ||
| v1.NotImplCloudClient | ||
| refID string | ||
| location string | ||
| client *sfc.SDK | ||
| logger v1.Logger | ||
| } | ||
|
|
||
| var _ v1.CloudClient = &SFCClientV2{} | ||
|
|
||
| type SFCClientV2Option func(c *SFCClientV2) | ||
|
|
||
| func WithLogger(logger v1.Logger) SFCClientV2Option { | ||
| return func(c *SFCClientV2) { | ||
| c.logger = logger | ||
| } | ||
| } | ||
|
|
||
| func (c *SFCCredentialV2) MakeClientWithOptions(_ context.Context, location string, opts ...SFCClientV2Option) (v1.CloudClient, error) { | ||
| sfcClient := &SFCClientV2{ | ||
| refID: c.RefID, | ||
| location: location, | ||
| client: sfc.New(sfc.WithSecurity(c.APIKey)), | ||
| logger: &v1.NoopLogger{}, | ||
| } | ||
|
|
||
| for _, opt := range opts { | ||
| opt(sfcClient) | ||
| } | ||
|
|
||
| return sfcClient, nil | ||
| } | ||
|
|
||
| func (c *SFCCredentialV2) MakeClient(ctx context.Context, location string) (v1.CloudClient, error) { | ||
| return c.MakeClientWithOptions(ctx, location) | ||
| } | ||
|
|
||
| func (c *SFCClientV2) GetAPIType() v1.APIType { | ||
| return v1.APITypeGlobal | ||
| } | ||
|
|
||
| func (c *SFCClientV2) GetCloudProviderID() v1.CloudProviderID { | ||
| return CloudProviderID | ||
| } | ||
|
|
||
| func (c *SFCClientV2) GetReferenceID() string { | ||
| return c.refID | ||
| } | ||
|
|
||
| func (c *SFCClientV2) GetTenantID() (string, error) { | ||
| return "", nil | ||
| } | ||
|
|
||
| func (c *SFCClientV2) MakeClient(_ context.Context, location string) (v1.CloudClient, error) { | ||
| c.location = location | ||
| return c, nil | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
manually tested that this image works for us? Docker, UFW, etc?