Move .storybook to build/storybook, add config-aware build support. - #38683
Move .storybook to build/storybook, add config-aware build support.#38683goodov wants to merge 3 commits into
Conversation
github-actions
Bot
added
CI/run-audit-deps
📋 Code Owners Summary10 file(s) changed, 2 with assigned owners 2 team(s) affected: Owners and Their Files
|
|
Warning You have got a presubmit warning. Please address it if possible. Items: |
2552ee8 to
704e47a
Compare
|
A Storybook has been deployed to preview UI for the latest push |
704e47a to
57e5003
Compare
57e5003 to
3c5aeba
Compare
| config.update(options) | ||
| config.buildTargets = ['brave/build/storybook:storybook_deps'] | ||
|
|
||
| await util.buildTargets(config.buildTargets, config.defaultOptions) |
There was a problem hiding this comment.
Can we add an option to skip this, e.g. --skip-gn-deps? If I'm running the command many times in a session and I know I haven't changed any types then I would like to skip the GN time if it takes more than a couple of seconds to realize it doesn't need to compile. Restarting storybool can be necessary when adding new files or dependencies.
There was a problem hiding this comment.
disabled the build by default in dev mode and added -B flag to enable it. lmk what you think, the default can be the other way around, but since you mentioned you may restart storybook frequently, maybe it's better to have the default to be "disable gn build".
5 participants
Add support for buildconfig-aware storybook build.
This is not wired via GN at this point, because GN action will require explicit stories list and a proper deps tracking, which is another task to solve.