This repository was archived by the owner on Dec 12, 2018. It is now read-only.
Twitch panel now shows favicon and panel displays correctly for tipping - #177
Open
jasonrsadler wants to merge 1 commit into
Open
Twitch panel now shows favicon and panel displays correctly for tipping#177jasonrsadler wants to merge 1 commit into
jasonrsadler wants to merge 1 commit into
Conversation
18 tasks
jasonrsadler
force-pushed
the
twitch-panel-tip-lib
branch
4 times, most recently
from
November 21, 2018 02:42
42a0c5d to
d1b0776
Compare
jasonrsadler
force-pushed
the
twitch-panel-tip-lib
branch
12 times, most recently
from
December 2, 2018 18:50
1376727 to
3816335
Compare
jasonrsadler
changed the title
NejcZdovc
reviewed
Dec 3, 2018
NejcZdovc
reviewed
Dec 3, 2018
jasonrsadler
force-pushed
the
twitch-panel-tip-lib
branch
from
December 3, 2018 18:38
3816335 to
6b083e8
Compare
jasonrsadler
force-pushed
the
twitch-panel-tip-lib
branch
4 times, most recently
from
December 6, 2018 17:49
1960359 to
9350db7
Compare
jasonrsadler
force-pushed
the
twitch-panel-tip-lib
branch
2 times, most recently
from
December 6, 2018 19:49
d0046fc to
f2c5eff
Compare
diracdeltas
reviewed
Dec 6, 2018
diracdeltas
reviewed
Dec 6, 2018
diracdeltas
reviewed
Dec 6, 2018
diracdeltas
reviewed
Dec 6, 2018
diracdeltas
reviewed
Dec 6, 2018
Moving values to static Moved logging statement below empty string check Implemented evaluating for twitch publisher Push evaluation to ledger Expanded naming of blob evaluate members to describe better.
jasonrsadler
force-pushed
the
twitch-panel-tip-lib
branch
from
December 7, 2018 01:51
f2c5eff to
8036529
Compare
|
lgtm now (though i haven't functionally tested it) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core implementation: brave/brave-core#888
For brave/brave-browser#1814