Fix Electron backend URLs to respect configured GSM bind address - #534
Open
Chrisyk wants to merge 1 commit into
Open
Fix Electron backend URLs to respect configured GSM bind address#534Chrisyk wants to merge 1 commit into
Chrisyk wants to merge 1 commit into
Conversation
- Stats Page (main.ts & index.html) - Polling Backend (main.ts) - Texthook IPC (texthook.ts) - Obs IPC (obs.ts) - Texthooker Web Call (texthooking_page.py)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Electron and Python GSM backend URL construction to respect the configured
advanced.localhost_bind_addressinstead of hardcodinglocalhost.localhost_bind_addressfrom GSM config in ElectronlocalhostBindAddressthroughsettings.getSettingsTesting
npm exec -- vitest run --config vitest.config.ts electron-src/main/gsm_config.test.tsnpm run build:mainpython -m py_compile GameSentenceMiner/web/texthooking_page.pynpm run buildNotes
This fixes cases where GSM is bound to a non-localhost address, such as a Tailscale IP, causing Electron UI requests to
localhostto fail even though the backend is running. Fixes infinite loading in pages such as Stats, unreachable Texthooker URLs, and silent IPC failures when GSM is bound to a non-localhost address.