Frost signing scaffolding#83
Merged
Merged
Conversation
Addtionally, on boot the btc_server will generate the round 1 payload. In the future, once dkg is completed this can be skipped. Unless some force flag is passed in maybe
…ere is already a pk package
BatiGencho
reviewed
Feb 2, 2024
| anyhow = "1.0.71" | ||
| bitcoin = { version = "0.30.2", features = [ "base64", "rand", "serde" ] } | ||
| # TODO update this to the zcash frost library when tr is merged in | ||
| frost-secp256k1-tr = { git = "https://github.com/mimoo/frost", branch = "mimoo/fix5", features = ["serde", "serialization"] } |
There was a problem hiding this comment.
In your example previously, I see you are targeting the main branch, here you are using a given branch, is there a particular reason for that ?
Contributor
Author
There was a problem hiding this comment.
Yes. Taproot signings is not merged in to the main branch yet.
ZcashFoundation/frost#584
There was a problem hiding this comment.
all right, ok, did not know that. all good
| Some(TxOut { script_pubkey: self.change_script.clone(), value: amount }) | ||
| } | ||
| bdk::wallet::coin_selection::Excess::Change { amount, .. } => Some(TxOut { | ||
| script_pubkey: self.change_script.as_ref().expect("change script").clone(), |
Contributor
Author
There was a problem hiding this comment.
Here we dont want to panic. Good call. Will fix
Contributor
Author
There was a problem hiding this comment.
Fixed. Added a is_none check and return a new error variant
arminsabouri
force-pushed
the
arm/dkg-scaffolding
branch
from
46364cd to
a03f07c
Compare
BatiGencho
approved these changes
Feb 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea with this struct is to have a stateful data structure that is aware of the DKG key status and aware of the current signing session.
What I want to accomplish next is to have only the secrets persist somewhere and for the DKG struct to be initialized from secrets in the DB. There might be somewhere better to save the secrets. Still an open question
Another open question is how to generate the frost identifier.