[gtsam-4.2] Fix missing <bitset> include for hybrid test#2483
Open
YoshuaNava wants to merge 1 commit into
Open
[gtsam-4.2] Fix missing <bitset> include for hybrid test#2483YoshuaNava wants to merge 1 commit into
YoshuaNava wants to merge 1 commit into
Conversation
Member
|
Oh, we can’t just merge into a release branch. But @ProfFan might be able to include in a 4.2.1 upcoming release? |
Collaborator
|
Yeah I can include this in 4.2.1 |
Member
|
@ProfFan is there already a 4.2.1 PR? |
Collaborator
|
I am preparing a 4.2.1 release, first need to cherry-pick some good bug fixes to 4.2 tree |
Member
|
@ProfFan it seems you forgot to include in 4.2.1 ? |
Collaborator
|
Oh shoot I'm pretty sure I ran all tests but let me recheck tomorrow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a missing include to the test file
gtsam/hybrid/tests/testHybridEstimation.cpp. Test builds were falling on my PC with 18.1.3 due to the absence of this include.