Skip to content

Argon2 via OpenSSL >= 3.2#9602

Draft
ThomasWaldmann wants to merge 7 commits into
borgbackup:masterfrom
ThomasWaldmann:argon2-via-openssl32
Draft

Argon2 via OpenSSL >= 3.2#9602
ThomasWaldmann wants to merge 7 commits into
borgbackup:masterfrom
ThomasWaldmann:argon2-via-openssl32

Conversation

@ThomasWaldmann
Copy link
Copy Markdown
Member

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.75%. Comparing base (7b522d6) to head (8232e39).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9602      +/-   ##
==========================================
- Coverage   83.60%   79.75%   -3.86%     
==========================================
  Files          93       93              
  Lines       15717    15714       -3     
  Branches     2360     2360              
==========================================
- Hits        13140    12532     -608     
- Misses       1834     2464     +630     
+ Partials      743      718      -25     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@ThomasWaldmann ThomasWaldmann force-pushed the argon2-via-openssl32 branch 2 times, most recently from 745ffbd to b06e98b Compare May 11, 2026 20:55
@ThomasWaldmann ThomasWaldmann marked this pull request as draft May 11, 2026 20:55
@ThomasWaldmann
Copy link
Copy Markdown
Member Author

ThomasWaldmann commented May 11, 2026

Guess we need to wait for:

  • Ubuntu 26.04 github actions runner image
    https://github.com/actions/runner-images#available-images
  • NetBSD 11 via cross-platform-actions would be nice, but it also works with 10.1 and building openssl from source
  • Haiku r1beta6 via c-p-a would be nice, but it also works with r1beta5 and curling more recent openssl packages (hmm, there is also openssl 3.5.6 in haikuports, can we use that?)
  • Update: Haiku was removed from CI matrix for now.

@ThomasWaldmann ThomasWaldmann force-pushed the argon2-via-openssl32 branch 9 times, most recently from 18e786b to 252cf06 Compare May 11, 2026 23:35
@ThomasWaldmann ThomasWaldmann force-pushed the argon2-via-openssl32 branch 2 times, most recently from 8d665c0 to cb70e8d Compare June 6, 2026 20:34
- src/borg/crypto/low_level.pyx: implement `argon2_hash` using OpenSSL's
  `EVP_KDF` API for ARGON2 (requires OpenSSL >= 3.2.0).
- src/borg/crypto/key.py: switch to the native `argon2_hash` implementation,
  removing `argon2-cffi` dependency.
- setup.py: require OpenSSL >= 3.2.0 for the crypto extension to ensure
  ARGON2 KDF support is available.
- pyproject.toml: drop `argon2-cffi` dependency.
- docs: update installation requirements and security documentation to
  reflect the transition to OpenSSL for Argon2.
@ThomasWaldmann ThomasWaldmann force-pushed the argon2-via-openssl32 branch from cb70e8d to 8232e39 Compare June 7, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant