Skip to content

Try to fix Windows CI (GitHub Actions -- vcpkg manifest mode) #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefanseefeld merged 14 commits into from
Jun 21, 2026
Merged

Try to fix Windows CI (GitHub Actions -- vcpkg manifest mode) #518

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f11618c
Create vcpkg.json
stephengtuggy Jun 4, 2026
8638eea
Update test-windows.yml
stephengtuggy Jun 4, 2026
c77ed5d
Update test-windows.yml: Fix the `--with-boost-include` directory pas…
stephengtuggy Jun 17, 2026
210231a
List vcpkg directory contents, looking for config.hpp
stephengtuggy Jun 17, 2026
bd14940
vcpkg.json: Go back to the same commit for builtin-baseline as was us…
stephengtuggy Jun 18, 2026
5d00264
Merge branch 'boostorg:develop' into fix/windows-ci
stephengtuggy Jun 18, 2026
b101bc8
test-windows.yml: Set VCPKG_ROOT environment variable, etc.
stephengtuggy Jun 18, 2026
5f234ee
test-windows.yml: Make workflow much more like my other, working proj…
stephengtuggy Jun 18, 2026
7cf1dc4
test-windows.yml: Search the entire github.workspace directory and su…
stephengtuggy Jun 20, 2026
bc83f51
test-windows.yml: Update `microsoft/setup-msbuild` to latest version,…
stephengtuggy Jun 20, 2026
8ed3dbe
vcpkg.json: Go back to latest vcpkg release for builtin-baseline
stephengtuggy Jun 20, 2026
96a1891
test-windows.yml: Try again to set the correct with-boost-include dir…
stephengtuggy Jun 20, 2026
2732a51
test-windows.yml: Set VCPKG_INSTALLED_DIR env var, and use its value …
stephengtuggy Jun 21, 2026
2460f88
test-windows.yml: Forgot to include `/x64-windows/include` in `--with…
stephengtuggy Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 12 additions & 18 deletions .github/workflows/test-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,30 +10,24 @@ jobs:
matrix:
python-version: [3.7]

env:
VCPKG_DEFAULT_TRIPLET: 'x64-windows'
VCPKG_DEFAULT_HOST_TRIPLET: 'x64-windows'

steps:
- uses: actions/checkout@v5
- uses: actions/setup-python@v6
with:
python-version: ${{ matrix.python-version }}
- uses: microsoft/setup-msbuild@v2
- name: setup boost prerequisites
uses: lukka/run-vcpkg@v6
uses: lukka/run-vcpkg@b1a0dd252f06b9e25b3c022a9a03bd7a427fb6a2 # v11.6
with:
vcpkgGitCommitId: '88b1071e39f13b632644d9d953738d345a4ac055'
vcpkgDirectory: '${{ runner.workspace }}/vcpkg'
vcpkgTriplet: x64-windows
vcpkgArguments: >
boost-config
boost-core
boost-function
boost-graph
boost-iterator
boost-lexical-cast
boost-mpl
boost-preprocessor
boost-smart-ptr
boost-static-assert
boost-align
vcpkgDirectory: '${{ github.workspace }}/vcpkg'
runVcpkgInstall: true
- name: List directory contents
run: Get-ChildItem "${{ github.workspace }}/vcpkg" -Recurse -Force -File -Filter 'config.hpp'

@stefanseefeld stefanseefeld Jun 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps if you use -User . to start looking in the local directory instead of $github.workspace/vcpkg ?
Alternatively, I see that the install root can be set via the vcpkgArguments: '--x-manifest-root=${{ github.workspace }}/vcpkg' directive.

@stephengtuggy stephengtuggy Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command simply searches the <github workspace>/vcpkg directory and all subdirectories for a file named config.hpp. It is literally the equivalent of find "${{ github.workspace}}/vcpkg" -iname 'config.hpp' -type f. And it's not finding the file anywhere! I don't understand what is going on here. Why would this file not be present?

I'm not familiar with -User . in conjunction with the Get-ChildItem command. What would that do?

@stephengtuggy stephengtuggy Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the install root can be set using the vcpkgArguments parameter, but I'm not sure it's best practice to do so.

shell: pwsh
- name: setup faber
run: |
python -m pip install --upgrade pip
Expand All @@ -42,8 +36,8 @@ jobs:
- name: build
shell: cmd
run: |
faber --builddir=build cxx.name=msvc --log=commands --log=output --with-boost-include=${{ runner.workspace }}\vcpkg\installed\x64-windows\include -j4
faber --builddir=build cxx.name=msvc --log=commands --log=output --with-boost-include=${{ github.workspace }}\vcpkg\installed\x64-windows\include -j4
- name: test
shell: cmd
run: |
faber --builddir=build cxx.name=msvc --with-boost-include=${{ runner.workspace }}\vcpkg\installed\x64-windows\include -j4 test.report
faber --builddir=build cxx.name=msvc --with-boost-include=${{ github.workspace }}\vcpkg\installed\x64-windows\include -j4 test.report
20 changes: 20 additions & 0 deletions vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{
"$schema": "https://raw.githubusercontent.com/microsoft/vcpkg/master/scripts/vcpkg.schema.json",
"name": "boost-python",
"version-string": "1.91.0",
"builtin-baseline": "88b1071e39f13b632644d9d953738d345a4ac055",
"dependencies": [
"boost-config",
"boost-core",
"boost-function",
"boost-graph",
"boost-iterator",
"boost-lexical-cast",
"boost-mpl",
"boost-preprocessor",
"boost-smart-ptr",
"boost-static-assert",
"boost-align",
"python3"
]
}
Loading