Add wall-clock alignment for recording segments - #5940
Open
Shulepov wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recording segments are currently split relative to the moment recording starts. For example, with
recordSegmentDuration: 1h, if a stream starts or reconnects at 12:13, segments are createdaround 12:13-13:13, 13:13-14:13, and so on.
For archival recording, it is often more useful to split files on wall-clock boundaries, such as 12:00-13:00, 13:00-14:00, or 12:00-12:05, 12:05-12:10. This makes recorded files easier to
browse, correlate with external systems, export, and manage with retention or post-processing jobs.
This PR adds an optional
recordSegmentDurationAlignedsetting. When enabled, segment rotation is aligned to wall-clock boundaries based onrecordSegmentDuration. The default remainsunchanged, so existing configurations keep the current behavior.
The first segment after startup or reconnection can be shorter than
recordSegmentDuration, and actual segment switches still happen on the first suitable random access point near the alignedboundary.