fix: handle DTS discontinuity by resetting extractor on error - #5896
Open
keks2293 wants to merge 1 commit into
Open
fix: handle DTS discontinuity by resetting extractor on error#5896keks2293 wants to merge 1 commit into
keks2293 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: recover from DTS extractor error instead of killing the stream
Problem
When
DTSExtractor.Extract()returns an error (e.g., non-monotonic DTS on camerareconnect, stream discontinuity, or DTS > PTS), mediamtx returns the error which
terminates the entire stream.
This happens frequently with IP cameras that lose signal and reconnect, resetting
their DTS to 0. The stream is killed for a temporary condition.
Fix
Instead of propagating the error, reset the DTS extractor to nil and drop the frame.
The extractor will be recreated on the next IDR/random access frame, and the stream
continues normally.
Rationale