[clang] Describe builtin templates instead of crashing - #315
Open
Cfretz244 wants to merge 1 commit into
Open
Conversation
DescriptionOf's ReflectionKind::Template switch had no arm for
BuiltinTemplateDecl: a metafunction error path describing one (the global
namespace enumerates __make_integer_seq et al., reachable from any
namespace-scope scan) hit llvm_unreachable("unhandled template kind")
while BUILDING the diagnostic. Add BuiltinTemplateDecl /
TemplateTemplateParmDecl arms and a generic fallback -- a description
helper feeding diagnostics must degrade, never crash.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #311.
DescriptionOf'sReflectionKind::Templateswitch had no arm forBuiltinTemplateDecl: a metafunction error path describing one (the global namespace enumerates__make_integer_seqet al., reachable from any namespace-scope scan) hitllvm_unreachable("unhandled template kind")while building the diagnostic. AddBuiltinTemplateDecl/TemplateTemplateParmDeclarms and a generic fallback — a description helper feeding diagnostics must degrade, never crash.Includes a verify-style regression test asserting the clean diagnostic (including the new "a builtin template" wording) on the exact field shape.
Validation (Apple Silicon, Release+assertions, base
837da39):clang/test/Reflectionat parity with base;