-
Notifications
You must be signed in to change notification settings - Fork 7
feat(api)!: retire DAO-API drafts + migrate to User API #2046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f856e84
feat(api)!: remove draft-proposal endpoints (moved to User API)
brunod-e 0502116
feat(user-api): one-shot draft migration script (DAO db -> User db)
brunod-e 550b982
Merge branch 'feat/user-accounts-dashboard' into feat/user-drafts-cut…
brunod-e 181851c
Merge branch 'feat/user-accounts-dashboard' into feat/user-drafts-cut…
brunod-e 80dad0e
Merge branch 'feat/user-accounts-dashboard' into feat/user-drafts-cut…
brunod-e cdeb3ab
Merge branch 'feat/user-accounts-dashboard' into feat/user-drafts-cut…
brunod-e 77ef83f
Merge branch 'feat/user-accounts-dashboard' into feat/user-drafts-cut…
brunod-e afaa05e
Merge branch 'feat/user-accounts-dashboard' into feat/user-drafts-cut…
brunod-e b27bd78
Merge branch 'feat/user-accounts-dashboard' into feat/user-drafts-cut…
brunod-e 0afe50f
Merge branch 'feat/user-accounts-dashboard' into feat/user-drafts-cut…
brunod-e File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| "@anticapture/api": minor | ||
| "@anticapture/gateful": minor | ||
| "@anticapture/client": major | ||
| --- | ||
|
|
||
| Remove the draft-proposal endpoints from the DAO APIs — drafts now live in the User API (user-scoped, session-authenticated). The `/{dao}/proposal/drafts*` routes, their controller/service/repository/mappers, and the `general` Postgres schema wiring are gone from `@anticapture/api`; the gateway spec and the generated `@anticapture/client` SDK no longer expose any `Draft*` fetchers, hooks, MCP tools, or models (breaking for external SDK consumers). The physical `general.proposal_drafts` table is left intact in each DAO database for the one-shot migration into the User API; a follow-up drops it. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this commit removes
/{dao}/proposal/drafts*from the DAO API and therefore from Gateful's OpenAPI surface, keeping@anticapture/apiand@anticapture/gatefulatminorlets release automation publish a non-breaking version even though REST clients calling those endpoints will fail after deploy. Please make these package changesets major as well; the generated client is already correctly marked major.Useful? React with 👍 / 👎.