Extract sub-row builders and refactor DmfsTaskBuilder to Entity-based approach#366
Draft
sunkup wants to merge 1 commit into
Draft
Extract sub-row builders and refactor DmfsTaskBuilder to Entity-based approach#366sunkup wants to merge 1 commit into
sunkup wants to merge 1 commit into
Conversation
…proach Extract ListIdBuilder, AlarmsBuilder, CategoriesBuilder, CommentsBuilder, RelationsBuilder, and UnknownPropertiesBuilder from DmfsTaskBuilder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #357. Part of #340.
Extract
ListIdBuilder,AlarmsBuilder,CategoriesBuilder,CommentsBuilder,RelationsBuilder, andUnknownPropertiesBuilder. Sub-row builders useEntity.addSubValue()instead of writing ContentProviderOperation rows directly, keeping all logic in the builder class.DmfsTaskBuilderis now a thin orchestrator:buildTask()returns anEntitypopulated by all field buildersaddRows()inserts the main row then each sub-value with a back-reference to the task IDupdateRows()updates the main row (removingLIST_ID) and inserts sub-values with the existing task IDinsertAlarms/insertCategories/insertComment/insertRelatedTo/insertUnknownPropertiesprivate methods and thewithTaskId()helper are removedinsertProperties()is kept as a no-op for backwards compatibility withDmfsTaskEach builder has a corresponding unit test.
Depends on #358 #363 #364 #365