AccountId refactoring (part 17) - #2810
Open
cketti wants to merge 2 commits into
Open
Conversation
cketti
marked this pull request as ready for review
August 13, 2026 17:28
cketti
force-pushed
the
2033-switch-to-AccountId-17
branch
from
August 14, 2026 12:09
136af7c to
340d3e7
Compare
cketti
force-pushed
the
2033-switch-to-AccountId-17
branch
from
August 14, 2026 12:22
340d3e7 to
a3e18c4
Compare
ArnyminerZ
approved these changes
Aug 15, 2026
Member
There was a problem hiding this comment.
suggestion: Maybe it is better to move it to core and mark it as @TestOnly? Then we don't duplicate it, and we can also make AccountSettingsStore a sealed interface. I believe it will be minified and removed anyway during build, so it doesn't affect the final app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AccountManagerSettingsStoreback toAccountSettings.AccountSettingsMigrationto useAccountIdandAccountSettingsStore.Closes #2033