BIP174: Mention sighash type requirement in Input Finalizer section#2182
Merged
murchandamus merged 1 commit intoMay 29, 2026
Merged
Conversation
This mirrors the existing PSBT_IN_SIGHASH_TYPE constraint from the per-input field description. Added to the Input Finalizer section so it is not missed.
jonatack
added
Proposed BIP modification
Member
|
ACK 9633048 |
murchandamus
removed
the
Pending acceptance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mention the
PSBT_IN_SIGHASH_TYPEconstraint in the Input Finalizer section. This mirrors the description of the per-input field.Rationale
Implementers of the Input Finalizer role have been missing this check.