[ENH] Add OME-Zarr as a supported format for imaging data#2392
[ENH] Add OME-Zarr as a supported format for imaging data#2392kabilar wants to merge 14 commits intobids-standard:masterfrom
Conversation
|
I fixed most of the CI failures. The remaining 2 failures appear unrelated. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2392 +/- ##
=======================================
Coverage 83.07% 83.07%
=======================================
Files 22 22
Lines 1696 1696
=======================================
Hits 1409 1409
Misses 287 287 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
effigies
left a comment
There was a problem hiding this comment.
I support this. It is in line with the decision made at the Copenhagen 2023 meeting which was: HDF5 and Zarr are preferred formats for new multi-dimensional data.
It looks like we dropped the ball on the wording in #1614, but I do think the decision should hold, nonetheless.
| Spatial metadata (such as the axis names and units, and coordinate transformations) SHOULD | ||
| be stored within the OME-Zarr metadata following the | ||
| [OME-Zarr version 0.5 specification](https://ngff.openmicroscopy.org/specifications/0.5/index.html) | ||
| (the latest released version). |
There was a problem hiding this comment.
I thought to scream "duplication is evil!" but apparently we do not really disclose much in microscopy section about OME or NGFF
❯ git grep -i -e OME.Zarr -e ngff -- src/modality-specific-files/microscopy.md
src/modality-specific-files/microscopy.md:file's header. Further, OME-ZARR (sometimes referred to as OME-NGFF or NGFF) has been developed to provide improved
src/modality-specific-files/microscopy.md:- [OME-ZARR/NGFF](https://ngff.openmicroscopy.org/latest/) (`.ome.zarr` directories)
but then we should at least take an opportunity to point to this section here from within that microscopy.md section. attn @bids-standard/bep031
There was a problem hiding this comment.
Good idea. I have just pushed a commit.
| compressed NIfTI files (.nii.gz), either version 1.0 or 2.0. If using compressed files, | ||
| Imaging data SHOULD be stored using the NIfTI file format. | ||
| Large imaging data MAY instead be stored using the | ||
| [OME-Zarr (OME-NGFF)](https://ngff.openmicroscopy.org/) file format. |
There was a problem hiding this comment.
I wonder if some schema-level check /could/should be added here based on some characteristics of the volume(s) -- e.g. any dimension having over 1k elements?
There was a problem hiding this comment.
Could: yes
checkname:
issue: ...
selectors:
- type(nifti_header) != 'null'
checks:
- max(nifti_header.shape) <= 1000Should: 🤷🏻
There was a problem hiding this comment.
Thanks. I don't feel too strongly here, but if we do add a check let's use level: warning.
|
That's shaping up nicely! Please complement with a PR against bids-examples which would demo some fake dataset with .ome.zarr . FWIW -- here I am creating one but scripting so I could easily recreate etc |
Thanks @yarikoptic. There was already a |
Fix #1704
cc @satra @balbasty @ayendiki