rf(schema): Consolidate rules.dataset_metadata under rules.json#2348
Open
effigies wants to merge 6 commits intobids-standard:masterfrom
Open
rf(schema): Consolidate rules.dataset_metadata under rules.json#2348effigies wants to merge 6 commits intobids-standard:masterfrom
rules.dataset_metadata under rules.json#2348effigies wants to merge 6 commits intobids-standard:masterfrom
Conversation
9e82aee to
761027b
Compare
bendhouseart
approved these changes
Feb 27, 2026
Collaborator
bendhouseart
left a comment
There was a problem hiding this comment.
Agree, it's slightly more intuitive.
Collaborator
Author
|
Tempting @yarikoptic into reviewing with a promise of a more consistent schema. |
761027b to
dbd4448
Compare
dbd4448 to
d1b879f
Compare
Collaborator
|
doesn't this change/break metaschema and thus requiring boost of https://github.com/bids-standard/bids-specification/blob/master/src/schema/SCHEMA_VERSION to 2.0.0-dev? |
Collaborator
Author
|
It seemed like a relatively small schema change, so I figured the minor version bump would be fine, but I have no objection to calling it major. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a slight cleanup.
rules.dataset_metadataandrules.jsondeveloped in parallel, but are ultimately the same thing. This makes it easier on schema users to find the rules that apply to any given JSON file by consolidating all underrules.json.I did move the
dataset_description_with_geneticsrule torules.json.geneticsinstead ofrules.json.dataset, since those rules were introduced in the genetics BEP. It could also be argued that it should go underrules.json.dataset, since it directly impactsdataset_description.json. The location has no impact on validation, it's just a question of what's most intuitive.