chore: clippy round across the workspace#449
Merged
Merged
Conversation
Co-authored-by: Claude <noreply@anthropic.com>
Base automatically changed from
phase4-threshold-tuning
to
phase1-doctor-into-alertd
June 2, 2026 14:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Final step of the healthcheck-consolidation series (stacked on #442). A workspace-wide clippy round addressing every warning, regardless of which crate it belongs to.
cargo clippy --workspace --all-targets --all-featuresfixes (all in the bestool iti modules):battery.rs:filter(..).next()→find(..);map_or(false, ..)→is_some_and(..); the partial-ord negation rewritten viapartial_cmp(preserving the NaN/zero behaviour).lcd.rs:== false→!.sparks.rs: dropped a needless borrow;repeat(0.0).take(n)→repeat_n(0.0, n).The whole stack is now rebased on current main, builds clean,
cargo fmt --checkclean, zero clippy warnings, tests pass against the local central DB, and the Windows GNU cross-check is clean.