2: #390 async GoodJob sync onto main#510
Open
superconductor-for-github[bot] wants to merge 47 commits into
Open
2: #390 async GoodJob sync onto main#510superconductor-for-github[bot] wants to merge 47 commits into
superconductor-for-github[bot] wants to merge 47 commits into
Conversation
Late days column Added one minor logic fix, resolved merge conflict due to UI change. All tests are passing
Enable/ Disable assignments update_all method fixed. Skip rubocop validations
… not being one(no canvas association) => Fail after 1s
Sync PR #390 (async sync via GoodJob) with current berkeley-cdss/main. Reuses #394/#392 resolutions and integrates the async feature: - perform_later + GoodJob adapter (external execution mode in tests) - adapted #390's controller/UI from old auth (@role/@is_course_admin/@user) to main's current_user/staff_user?; kept main's display_role + last-synced UI - regenerated schema with good_jobs tables + notes column - adapted new sync_users_from_canvas_job_spec to the Enrollment model Full RSpec suite green (587); RuboCop clean.
…ance) Run GoodJob via execution_mode = :async in production (inherited by staging), so the single EB web instance processes background jobs in its own thread pool without a separate worker process or tier — and without depending on EB starting a Procfile `worker`. - production.rb: async execution mode + tunable max_threads/poll_interval/queues - database.yml: size prod/staging pool for Puma threads + GoodJob threads + listener - Procfile: drop the now-redundant `worker` entry (documented how to re-enable) good_jobs tables are created on deploy by the existing db:migrate step (.ebextensions/02_migrations.config).
- Edit Notes button: btn-outline-secondary (California gold #FDB515 on white, 1.78:1) -> btn-outline-primary, which is already tuned for AA contrast in both light and dark themes. - 'No notes yet.' placeholder: .text-muted inside a .bg-light box washed out in dark mode (1.16:1) because bg-light keeps a light surface while text-muted goes near-white. Pin .text-muted to a readable gray within the dark-theme .bg-light override (same pattern already used there for p/li/strong). Verified: full a11y suite (spec/ --tag a11y) 40 examples, 0 failures.
cycomachead
changed the title
Re-sync with main after #509 (late days column) merged. Clean auto-merge; schema retains good_jobs tables + notes column. Full RSpec (594) + a11y (40) green; RuboCop clean.
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview-only sync of #390 (async sync via GoodJob) onto current
main.Preserves PR #390 history (stacked on #392/#394) and merges current
main, reusing the earlier resolutions and integrating the async feature onto main's refactored code.Key resolutions:
Course#sync_*nowperform_later; added GoodJob adapter +config/initializers/good_job.rb; tests usegood_job.execution_mode = :external.@role,@is_course_admin,@user) to main'scurrent_user/@course.staff_user?. Newsync_status+bulk_update_assignmentsguarded bystaff_user?.display_roleand last-synced-at UI; layered SP26 #5: (89) Make sync enrollments and sync assignments async with Good_job gem and Added good_job gem dashboard permission control #390's async spinner buttons.sync_users_from_canvas_job_specto theEnrollmentmodel.Full RSpec suite green (587 examples); RuboCop clean.
Original PR: #390 · Stacked on #509