chore(deps): bump sqlite3vfs upstream#1359
Open
corylanou wants to merge 2 commits into
Open
Conversation
PR Build Metrics✅ All clear — no issues detected
Binary Size
Dependency ChangesAdded:
Removed:
govulncheck OutputBuild Info
History (1 previous)
🤖 Updated on each push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps
github.com/psanford/sqlite3vfsfromv0.0.0-20251127171934-4e34e03a991ato upstream commitf9180fa2acc9, resolved asv0.0.0-20260519004904-f9180fa2acc9.Upstream has no tag at this commit. The PR also enforces and documents SQLite 3.31.0 as the minimum runtime version for the loadable VFS extension.
Motivation and Context
Upstream commit
f9180fa2acc9adds URI opener support, so Litestream can consume the upstream implementation targeted by item 1 of #1355.SQLite runtime compatibility
The upstream implementation calls
uriParamsFromC(name)before itsURIOpenerinterface check. That function immediately callss3vfsURIKey(), which unconditionally dereferences the loadable-extension table'ssqlite3_uri_keyentry for every non-null VFS open. The default VFS wrapper also implementsOpenURI, so the interface check does not gate access to this API.SQLite added
sqlite3_uri_key()in 3.31.0. With SQLite 3.30.1, opening through the bumped VFS reproduced aSIGBUSaturiParamsFromC -> s3vfsURIKey. The extension entrypoint now checkssqlite3_libversion_number()before registering the VFS and returns a normal load error for older runtimes.Scope
In scope:
sqlite3vfsdependencyNot in scope:
Those are item 2 of #1355 and remain a separate follow-up.
How Has This Been Tested?
go test -tags vfs -race ./cmd/litestream-vfs— passmake vfs— passSIGBUSaturiParamsFromC -> s3vfsURIKeylitestream VFS requires SQLite 3.31.0 or later (found 3.30.1)3.31.0go test -tags vfs -race ./cmd/litestream-vfs -run '^TestVFS_SortingLargeResultSet$' -count=1— pass after one full-package rerun timed out in this existing testgo mod verify— passpre-commit run --all-files— passgo test -tags vfs -race ./...— all packages except the root package pass; the root package does not compile because VFS-only mocks invfs_test.goare missing the existingReplicaClient.SetLoggermethod. The identical failure reproduces on pristineorigin/mainwithgo test -tags vfs -race ..Types of changes
Checklist
go fmt,go vet)go test ./...)Related to #1355 (item 1).