Skip to content

fix: don't crash the quantile token loss when no kernel is configured #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brettbj wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: don't crash the quantile token loss when no kernel is configured #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions src/cotorra/loss.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,9 @@ def __init__(self, cfg=None, tkzr_cfg=None):
self.loss_function = self.loss_functions[self.cfg.quantile_token_loss.loss_type]
else:
self.loss_function = t.nn.MSELoss
if "kernel" in self.cfg.quantile_token_loss:
if "type" in self.cfg.quantile_token_loss.kernel:
self.kernel_type = self.cfg.quantile_token_loss.kernel.type
else:
self.kernel_type = "linear"
if "factor" in self.cfg.quantile_token_loss.kernel:
self.kernel_factor = self.cfg.quantile_token_loss.kernel.factor
kernel_cfg = self.cfg.quantile_token_loss.get("kernel", {})
self.kernel_type = kernel_cfg.get("type", "linear")
self.kernel_factor = kernel_cfg.get("factor", 1.0)


def quantile_token_loss(self, outputs, labels, **kwargs):
Expand All @@ -93,7 +89,7 @@ def aggregate_first(cat_logits, cat_labels, i):
self.label_to_q[self.label_to_cat == i]
).to(device=cat_logits.device)
cat_true = self.label_to_q.to(device=cat_labels.device)[cat_labels]
if self.cfg.quantile_token_loss.kernel.type in self.kernels:
if self.kernel_type in self.kernels:
kernel = self.kernels[self.kernel_type]
cat_preds = kernel(cat_preds, self.kernel_factor)
cat_true = kernel(cat_true, self.kernel_factor)
Expand All @@ -103,7 +99,7 @@ def loss_first(cat_logits, cat_labels, i):
values =(
self.label_to_q[self.label_to_cat == i]
).to(device=cat_logits.device)
if self.cfg.quantile_token_loss.kernel.type in self.kernels:
if self.kernel_type in self.kernels:
kernel = self.kernels[self.kernel_type]
values = kernel(values, self.kernel_factor)
cat_true = kernel(cat_true, self.kernel_factor)
Expand Down