-
Notifications
You must be signed in to change notification settings - Fork 275
WS-2610: Sport Data Polling (Front end changes) #14015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 42 commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
8df78dd
WS-2610: Initial commit
Isabella-Mitchell 28f453a
WS-2610: Simplifies hook.
Isabella-Mitchell 09d10b8
WS-2610: Demo option without comparison
Isabella-Mitchell 4d0cf6a
WS-2610: Co-locate polling with sports header
Isabella-Mitchell 2ef3e04
Merge branch 'latest' into WS-2610-sport-data-polling
Isabella-Mitchell 37a6c86
WS-2610: Refines: handles expected data structure
Isabella-Mitchell 0a1f3d0
WS-2610: Extends makeRequest. Adds unit tests
Isabella-Mitchell f250e5f
WS-2610: Tidy
Isabella-Mitchell fbf0fdd
Merge branch 'latest' into WS-2610-sport-data-polling
Isabella-Mitchell 4fa752e
WS-2610: fix types. Delete fake fetcher
Isabella-Mitchell 9386526
WS-2610: temp fix
Isabella-Mitchell 7237dba
WS-2610: Fix type
Isabella-Mitchell fe85bff
Add toggles
hotinglok 167f5b9
Add toggles to configs
hotinglok c3bf0ac
Update snapshots
hotinglok c00be4c
Add boolean constructor to toggle values
hotinglok 16ed143
Remove unused import
hotinglok 52d804a
WS-2610: Adds polling route
Isabella-Mitchell caf87ce
WS-2610: Mocks polling in unit tests
Isabella-Mitchell 60d7336
Merge branch 'latest' into WS-2610-sport-data-polling
Isabella-Mitchell e73c095
WS-2610: Updates tests. Resolves other errors
Isabella-Mitchell 866bb65
WS-2610: Tidies
Isabella-Mitchell c670535
WS-2610: Fix stories
Isabella-Mitchell 9c28791
WS-2610: Copilot review suggestions
Isabella-Mitchell 5f881ea
WS-2610: Fix type error
Isabella-Mitchell af7e95f
WS-2610: Renames file to index
Isabella-Mitchell 7ab2de0
Revert "WS-2610: Renames file to index"
Isabella-Mitchell eaa25c1
WS-2610: Renames correct file to index
Isabella-Mitchell 1b94624
WS-2610: Does not reassign variable
Isabella-Mitchell 3bedd23
Merge branch 'latest' into WS-2610-sport-data-polling
Isabella-Mitchell 2b812f4
WS-2610: rename sports to sport in request
Isabella-Mitchell 902b8b2
WS-2610: Rename sports to sport in hook
Isabella-Mitchell 01018e1
Merge branch 'WS-2610-sport-data-polling' into WS-2621-add-sport-head…
hotinglok 9ac44d7
Fix tests
hotinglok 9bdf137
WS-2610-extra: Update param
Isabella-Mitchell c957f9f
Fix story
hotinglok 33f9ff5
Merge pull request #14032 from bbc/WS-2621-add-sport-header-toggles
hotinglok c724423
Merge branch 'WS-2610-sport-data-polling' into WS-2610-extra
hotinglok 44d8573
Merge pull request #14043 from bbc/WS-2610-extra
hotinglok e70c87c
Merge branch 'latest' into WS-2610-sport-data-polling
hotinglok 223841f
Merge branch 'latest' into WS-2610-sport-data-polling
Isabella-Mitchell c8038b5
WS-2610: Amends polling fixture data based on real request
Isabella-Mitchell f90ff03
WS-2610: Updates types [copilot]
Isabella-Mitchell 90b88f1
Merge branch 'latest' into WS-2610-sport-data-polling
Isabella-Mitchell 462e93c
WS-2610-extra: missed commit
Isabella-Mitchell ad2bdc5
Revert "WS-2610-extra: missed commit"
Isabella-Mitchell 90c333d
Revert "WS-2610: Updates types [copilot]"
Isabella-Mitchell 3f67dea
WS-2610: Refactors approach
Isabella-Mitchell 43ea9eb
WS-2610-extra: Fix tests
Isabella-Mitchell 7e032a7
WS-2610: Simplifies test suit
Isabella-Mitchell d8c4d8d
Merge branch 'WS-2610-sport-data-polling' into WS-2610-extra-adjust-e…
Isabella-Mitchell b9b60c2
Merge pull request #14052 from bbc/WS-2610-extra-adjust-expected-data…
Isabella-Mitchell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
132 changes: 132 additions & 0 deletions
132
src/app/hooks/useSportDataPolling/fixture/fixtureSportData.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,132 @@ | ||
| export default { | ||
| urn: 'urn:bbc:sportsdata:football:event:s-3y91hnyfjh24yxjhm77a7hy50', | ||
| home: { | ||
| id: 'ej5er0oyngdw138yuumwqbyqt', | ||
| fullName: 'Bologna', | ||
| shortName: 'Bologna', | ||
| urn: 'urn:bbc:sportsdata:football:team:bologna', | ||
| runningScores: { | ||
| halftime: '0', | ||
| fulltime: '1', | ||
| aggregate: '1', | ||
| }, | ||
| scoreUnconfirmed: '1', | ||
| actions: [ | ||
| { | ||
| playerUrn: | ||
| 'urn:bbc:sportsdata:football:player:s-2bmeynv0dhsc8sjfuaprkexre', | ||
| playerName: 'J. Rowe', | ||
| actionType: 'goal', | ||
| actions: [ | ||
| { | ||
| type: 'Goal', | ||
| typeLabel: { value: 'Goal', accessible: 'Goal' }, | ||
| timeLabel: { | ||
| value: "90'", | ||
| accessible: '90 minutes', | ||
| }, | ||
| }, | ||
| ], | ||
| }, | ||
| ], | ||
| score: '1', | ||
| }, | ||
| away: { | ||
| id: 'b496gs285it6bheuikox6z9mj', | ||
| fullName: 'Aston Villa', | ||
| shortName: 'Aston Villa', | ||
| urn: 'urn:bbc:sportsdata:football:team:aston-villa', | ||
| runningScores: { | ||
| halftime: '1', | ||
| fulltime: '3', | ||
| aggregate: '3', | ||
| }, | ||
| scoreUnconfirmed: '3', | ||
| actions: [ | ||
| { | ||
| playerUrn: | ||
| 'urn:bbc:sportsdata:football:player:s-8qys6qtdwgsycxducl062zld5', | ||
| playerName: 'E. Konsa', | ||
| actionType: 'goal', | ||
| actions: [ | ||
| { | ||
| type: 'Goal', | ||
| typeLabel: { value: 'Goal', accessible: 'Goal' }, | ||
| timeLabel: { | ||
| value: "44'", | ||
| accessible: '44 minutes', | ||
| }, | ||
| }, | ||
| ], | ||
| }, | ||
| { | ||
| playerUrn: | ||
| 'urn:bbc:sportsdata:football:player:s-5m0j33eoa5c8pqlr0tdf7undh', | ||
| playerName: 'O. Watkins', | ||
| actionType: 'goal', | ||
| actions: [ | ||
| { | ||
| type: 'Goal', | ||
| typeLabel: { value: 'Goal', accessible: 'Goal' }, | ||
| timeLabel: { | ||
| value: "51'", | ||
| accessible: '51 minutes', | ||
| }, | ||
| }, | ||
| { | ||
| type: 'Goal', | ||
| typeLabel: { value: 'Goal', accessible: 'Goal' }, | ||
| timeLabel: { | ||
| value: "90'+4", | ||
| accessible: '90 minutes plus 4', | ||
| }, | ||
| }, | ||
| ], | ||
| }, | ||
| ], | ||
| score: '3', | ||
| }, | ||
| time: { | ||
| accessibleTime: '20:00', | ||
| displayTimeUK: '20:00', | ||
| timeCertainty: true, | ||
| }, | ||
| date: 'Thu 9 Apr 2026', | ||
| tournament: { | ||
| id: '4c1nfi2j1m731hcay25fcgndq', | ||
| name: 'UEFA Europa League', | ||
| disambiguatedName: 'UEFA Europa League', | ||
| urn: 'urn:bbc:sportsdata:football:tournament:europa-league', | ||
| thingsGuid: '2afbdda7-71d4-544d-bcc6-d9ff50314b2a', | ||
| }, | ||
| stage: { | ||
| id: '7wxuj38kqm8bz3cmi15vu4w7o', | ||
| name: 'Quarter-finals', | ||
| urn: '', | ||
| }, | ||
| multiLeg: { | ||
| leg: 1, | ||
| relatedMatchId: 's-9ur6e6w5f4ahyxph7ef4rks2c', | ||
| }, | ||
| period: 'ft', | ||
| venue: { | ||
| id: '2nrn0y55nz9ee7p9adzbb7fta', | ||
| urn: 'urn:bbc:sportsdata:football:venue:s-2nrn0y55nz9ee7p9adzbb7fta', | ||
| name: "Stadio Renato Dall'Ara", | ||
| shortName: "Stadio Renato Dall'Ara", | ||
| }, | ||
| attendance: { value: 31142 }, | ||
| status: 'PostEvent', | ||
| periodLabel: { value: 'FT', accessible: 'Full time' }, | ||
| winner: 'away', | ||
| tournamentDescriptionLabel: 'UEFA Europa League - Quarter-finals', | ||
| groupedActions: [ | ||
| { | ||
| groupName: { fullName: 'Assists', shortName: 'Assists' }, | ||
| homeTeamActions: ["J. Lucumí (90')"], | ||
| awayTeamActions: ["Y. Tielemans (44', 90'+4)", "E. Buendía (51')"], | ||
| }, | ||
| ], | ||
| accessibleEventSummary: 'Bologna 1 , Aston Villa 3 at Full time', | ||
| sportDiscipline: 'football', | ||
| }; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.