fix: deduplicate imported accounts after token rotation - #374
Open
zyxtoworld wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chatgpt_account_idso separate workspaces remain separate, with subject/email fallbacks only when the account ID is absentRoot cause
All account import paths converge on
AccountService._add_account_payloads:The shared method only deduplicated exact access-token strings. A refreshed token therefore created a second pool entry for the same ChatGPT account, and the subsequent refresh phase also requested that account twice.
Tests
main: 7 of 8 new behavior tests failed before the fixBaseline note: five unrelated image tests fail identically on unmodified upstream commit
e55aef2and this branch; they were excluded from the isolated 140-test pass set.