feat: handle laptop lid state in brightness-display#5815
Open
Acoowa wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR improves the system wake behavior for laptop users. Currently,
omarchy-system-wake(viaomarchy-brightness-display) unconditionally enables all displays. This causes the internal laptop screen to turn on even when the lid is closed, which is often undesirable when using an external monitor.Changes
/proc/acpi/button/lid/.eDP-1) usinghyprctl.jqis not installed or if it's running on a desktop without a lid sensor.Why this is needed
When a laptop is docked or connected to a TV, waking the system shouldn't light up the screen under the closed lid. This prevents "ghost" windows from being placed on an invisible screen and saves power/heat.
Testing
Tested on a laptop with an external monitor setup.