Screen recording: add optional max duration#5783
Closed
davidguttman wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Interesting idea, but can't say it's a problem I've ever had. We have the indicator in the menu to remind you that we're recording. But could be a neat script to add on your own setup, then bind a custom hotkey for it. That's the fun part of owning your own operating system! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5782.
Adds a Max duration submenu to the screenrecord flow (Unlimited / 15min / 30min / 1h / 2h). "Unlimited" is first and preserves today's behavior. When a finite duration is picked, an auto-stop is scheduled against the specific
gpu-screen-recorderPID, so a manual stop (Alt+Print or the waybar indicator) followed by a new recording can't be killed by an orphaned timer — the timer re-checks/proc/$pidbefore signaling.The duration prompt happens before
omarchy-capture-screenrecordingis invoked, so the prompt itself isn't captured. The two helpers (wait_for_screenrecorder_pid,schedule_screenrecord_autostop) keep the call site to a single line and document the safety property.Test plan