feat(report): group metrics by category in chart grid#189
Open
erhnysr wants to merge 1 commit into
Open
Conversation
Closes base#125 Adds metric grouping to the RunComparison chart grid. Metrics are now displayed under section headers instead of a flat list: - Latency: send_txs, update_fork_choice, get_payload, new_payload - Chain: inserts, account/storage reads/updates/commits, execution, validation, write, snapshot, triedb - Throughput: transactions/per_block, gas/per_block Changes: - Add optional group field to ChartConfig type - Annotate all metrics in CHART_CONFIG with their group - Refactor ChartGrid to group visible charts by category and render section headers between groups - Add CSS for .metric-group, .metric-group-title, .metric-group-charts
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #125
Problem
The RunComparison chart grid displayed all metrics as a flat list, making it hard to navigate when there are many metrics.
Solution
Metrics are now grouped under section headers:
Changes
groupfield toChartConfigtypeCHART_CONFIGwith their groupChartGridto group visible charts by category and render section headersBehaviour
Metrics with no group assigned fall into an
Othersection. Group order is: Latency → Chain → Throughput → Other.