Externalize creation of Chat collection view layout models#741
Open
jrcmramos-bumble wants to merge 2 commits into
Open
Externalize creation of Chat collection view layout models#741jrcmramos-bumble wants to merge 2 commits into
jrcmramos-bumble wants to merge 2 commits into
Conversation
|
您好,邮件收到
|
Codecov Report
@@ Coverage Diff @@
## master #741 +/- ##
==========================================
+ Coverage 54.84% 54.86% +0.01%
==========================================
Files 108 110 +2
Lines 5745 5760 +15
==========================================
+ Hits 3151 3160 +9
- Misses 2594 2600 +6
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR decouples the adapter from the creation of collection items diff.
Since this operation can take some time, this could block the release of ChatMessageCollectionAdapter, since it was retaining it.