Implement edge-to-edge mode - #109
Open
MrApplejuice wants to merge 7 commits into
Open
Conversation
Collaborator
Author
|
Added dedicated background spacer for the topbar and enabled extra "enforce" mode for the bottom bar: 
This pretty much concludes the edge to edge feature implementation. |
Comment on lines
+150
to
+159
| ViewCompat.setOnApplyWindowInsetsListener(it.root) { v, insets -> | ||
| val systemBars = insets.getInsets( | ||
| WindowInsetsCompat.Type.systemBars() | ||
| ) | ||
| v.setPadding(systemBars.left, 0, systemBars.right, 0) | ||
|
|
||
| binding.topSpacer.layoutParams.height = systemBars.top | ||
|
|
||
| WindowInsetsCompat.CONSUMED | ||
| } |
Comment on lines
+67
to
+71
| <LinearLayout | ||
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent" | ||
| android:background="?android:attr/colorBackground" | ||
| android:orientation="vertical"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement edge2edge mode in the most simple, but ugly way: A black/white top-bar followed by the app's content is a step-down in the general look and feel of the app, imo. I will check out later if this can be improved somehow...
Fixes #89
Fixes #118 as well now.