Skip to content

refactor: clean code improvements #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raymond-julie wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: clean code improvements #1429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions symja_android_library/matheclipse-external/src/main/java/edu/jas/application/WordIdeal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,11 +147,8 @@ public WordIdeal(GenWordPolynomialRing<C> ring, List<GenWordPolynomial<C>> list,
*/
public WordIdeal(GenWordPolynomialRing<C> ring, List<GenWordPolynomial<C>> list, boolean gb,
WordGroebnerBaseAbstract<C> bb, WordReduction<C> red) {
if (ring == null) {
throw new IllegalArgumentException("ring may not be null");
}
if (list == null) {
throw new IllegalArgumentException("list may not be null");
if (ring == null || list == null) {
throw new IllegalArgumentException("Neither ring nor list may be null");
}
this.ring = ring;
this.list = list;
Expand Down Expand Up @@ -197,7 +194,7 @@ public GenWordPolynomialRing<C> getRing() {
* @return ideal(0)
*/
public WordIdeal<C> getZERO() {
List<GenWordPolynomial<C>> z = new ArrayList<GenWordPolynomial<C>>(0);
List<GenWordPolynomial<C>> z = Collections.emptyList();
return new WordIdeal<C>(ring, z, true, bb, red);
}

Expand All @@ -207,7 +204,7 @@ public WordIdeal<C> getZERO() {
* @return ideal(1)
*/
public WordIdeal<C> getONE() {
List<GenWordPolynomial<C>> one = new ArrayList<GenWordPolynomial<C>>(1);
List<GenWordPolynomial<C>> one = Collections.singletonList(ring.getONE());
one.add(getRing().getONE());
return new WordIdeal<C>(ring, one, true, bb, red);
}
Expand Down
Loading