Add semgrep security scan for command injection in Windows files#4959
Open
KlwntSingh wants to merge 1 commit into
Open
Add semgrep security scan for command injection in Windows files#4959KlwntSingh wants to merge 1 commit into
KlwntSingh wants to merge 1 commit into
Conversation
- Detects execCommand/exec.Command with variable arguments - Detects unsanitized fmt.Sprintf into PowerShell commands - Scoped to *_windows.go files only - Auto-detects base branch for diff-aware scanning - Posts warnings as PR annotations and comments - Does not block merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds custom semgrep rules to detect potential command injection vulnerabilities (CWE-78) in Windows-specific code paths during PRs.
Implementation details
Two custom semgrep rules:
execCommand/exec.Command/exec.CommandContextcalls with variable (non-literal) argumentsfmt.Sprintfwith PowerShell-related format strings where variables are interpolatedBehavior
pull_requestonly_windowsin the filenameTesting
Validated on fork (KlwntSingh/amazon-ecs-agent2):
execCommand(var, ...)Note on PR #12: Rule 1 flags
execCommand("powershell.exe", args...)becauseargsis a variable, even though it's built from string literals. Semgrep cannot track that a variable was constructed from safe values. This is an acceptable false positive — it errs on the side of caution and prompts the developer to verify the code is safe.New tests cover the changes: no
Description for the changelog
security: add semgrep scan for command injection in Windows files
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.