Skip to content

fix: correct knob annotate() mem_space values and TileOp emission #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ymwangg wants to merge 1 commit into
base: pr-58
Choose a base branch
from
Open

fix: correct knob annotate() mem_space values and TileOp emission #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions nkigen/nkigen/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1605,7 +1605,7 @@ def annotate(

ms_attr = None
if mem_space is not None:
ms_map = {"Hbm": 0, "Psum": 1, "Sbuf": 2, "SharedHbm": 3}
ms_map = {"Hbm": 1, "Psum": 2, "Sbuf": 3, "SharedHbm": 4}
ms_attr = ir.IntegerAttr.get(ir.IntegerType.get_signless(32), ms_map[mem_space])

pd_attr = None
Expand All @@ -1616,9 +1616,12 @@ def annotate(
if tile_size is not None:
ts_attr = ir.DenseI64ArrayAttr.get(tile_size)

rt_attr = None
if reduction_tile is not None:
rt_attr = ir.DenseI64ArrayAttr.get(reduction_tile)
loop_tile = tile_size
if loop_tile is not None and reduction_tile is not None:
loop_tile = list(tile_size) + list(reduction_tile)
loop_tile_attr = None
if loop_tile is not None:
loop_tile_attr = ir.DenseI64ArrayAttr.get(loop_tile)

if ms_attr is not None or pd_attr is not None or ts_attr is not None:
nkipy_d.LayoutOp(
Expand All @@ -1629,11 +1632,10 @@ def annotate(
loc=loc,
)

if ts_attr is not None or rt_attr is not None:
if loop_tile_attr is not None:
nkipy_d.TileOp(
target=value,
loop_tile_size=ts_attr,
reduction_tile=rt_attr,
loop_tile_size=loop_tile_attr,
loc=loc,
)
return x
Expand Down