fix(authenticator): Add accessible names for password toggle and form errors - #7229
Closed
VarshithaPamisetty wants to merge 2 commits into
Closed
Conversation
… errors Adds tooltip/accessible names to the password visibility toggle so screen readers announce "Show password"/"Hide password", and wraps banner and form content in semantics so validation errors are announced. Tooltip strings are defined in the inputs ARB source (inputs_en.arb) and reflected in the generated localizations. Continues the work in aws-amplify#6577 by @ekjotmultani. Issues: aws-amplify#6568 aws-amplify#6581
Contributor
Author
|
@ekjotmultani @cadivus this continues #6577 with the review fixes. Could you review and approve the CI run when you get a chance? Thanks! |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7229 +/- ##
==========================================
+ Coverage 40.97% 41.24% +0.26%
==========================================
Files 121 121
Lines 8273 8288 +15
Branches 3598 3604 +6
==========================================
+ Hits 3390 3418 +28
+ Misses 4883 4870 -13 🚀 New features to boost your workflow:
|
cadivus
reviewed
Aug 10, 2026
Comment on lines
+207
to
+209
| // Workaround for Flutter issue where validation errors are not | ||
| // announced by screen readers on web unless helperText is set. | ||
| // See: https://github.com/flutter/flutter/issues/99715 |
Member
There was a problem hiding this comment.
I like that you reference the issue that leads to such a "weird" workaround.
Contributor
Author
|
Superseded by #7254, reopened from an upstream branch so CI runs without the fork-secret issues. Continuing there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #6568
Fixes #6581
Description:
Continues the work in #6577 by @ekjotmultani, addressing the review feedback.
Adds tooltip/accessible names to the password visibility toggle so screen readers announce "Show password"/"Hide password" (#6568), and wraps banner and form content in semantics so validation errors are announced (#6581).
Review follow-ups from #6577:
helperTextis set on the input fields as a workaround for [a11y] VoiceOver does not announce form validation errors flutter/flutter#99715 so validation errors are announced on web; this adds a consistent helper line under every field, which the updated golden snapshots reflect.Tests
dart analyzeanddart formatclean.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.