Conversation
* migration from golangci-lint v1 to v2
maranqz
commented
Feb 8, 2026
| } | ||
|
|
||
| func (r *readonlyFuncWithoutTxDecorator) Keys(ctx context.Context, pattern string) *redis.StringSliceCmd { | ||
| func (r *readonlyFuncWithoutTxDecorator) Keys( |
Member
Author
There was a problem hiding this comment.
rollback and add exclude for linter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces experimental commit and rollback hooks and transaction metadata (TxInfo) to
go-transaction-managerwithout breaking the existingtrm.TransactionAPI and without requiring a v3 release.The change is fully opt-in and implemented via a context-carried wrapper (
XTransaction), preserving backward compatibility while enabling richer lifecycle instrumentation and control.Motivation
Many real-world use cases require reacting to transaction lifecycle events:
Today,
go-transaction-managerprovides strong propagation semantics but no official hook mechanism. This PR introduces a minimal, controlled extension that enables:…while explicitly avoiding any breaking changes.