Skip to content

chore(trackers): log which rename signal fired#262

Open
maksii wants to merge 1 commit into
mainfrom
chore/log-rename-signal
Open

chore(trackers): log which rename signal fired#262
maksii wants to merge 1 commit into
mainfrom
chore/log-rename-signal

Conversation

@maksii

@maksii maksii commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

isRenamedRelease fires on three separate heuristics — the srrdb scene comparison, an *arr rename token, and the space-rename check — but reports a deliberately generic user-facing reason for all three, since the reason is disclosed and must not reveal which detection tripped.

That left no way to tell them apart when diagnosing a false positive. A user reports "modified_release fired and it shouldn't have" and there is nothing in the logs saying which of the three did it.

isRenamedRelease now returns the signal name (srrdb, arr-token, space-rename) as a third value, and EvaluateRules logs it at debug alongside the source path, video path and group. The disclosed reason is unchanged — the signal is logging-only, which the doc comment states explicitly so nobody wires it into user-facing output later.

Pure observability, no behaviour change. go build ./..., go vet and the trackers suite (28 packages) pass.

The modified-release rule reports a deliberately generic user-facing reason, so
a failure gave no indication of which of the three heuristics tripped it. Name
the signal alongside the reason and log it, leaving the disclosed reason
unchanged.
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@maksii, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 39 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 11014913-ba15-4535-bb42-4d9562dbea24

📥 Commits

Reviewing files that changed from the base of the PR and between 5a00fc7 and 22106d0.

📒 Files selected for processing (3)
  • internal/trackers/modified_release.go
  • internal/trackers/modified_release_test.go
  • internal/trackers/rules.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/log-rename-signal

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant