feat: add cursor and limit support to relationship read - #683
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #683 +/- ##
==========================================
+ Coverage 43.21% 43.93% +0.71%
==========================================
Files 38 38
Lines 6090 6109 +19
==========================================
+ Hits 2632 2684 +52
+ Misses 3190 3148 -42
- Partials 268 277 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tstirrat15
reviewed
Apr 28, 2026
Comment on lines
+287
to
+290
| var lastCursor *v1.Cursor | ||
| if cursorStr := cobrautil.MustGetString(cmd, "cursor"); cursorStr != "" { | ||
| lastCursor = &v1.Cursor{Token: cursorStr} | ||
| } |
Contributor
There was a problem hiding this comment.
This is the input of the page
Comment on lines
+840
to
+847
| func makeTestCallback() (func(_ *cobra.Command, responses []*v1.ReadRelationshipsResponse) error, *[][]*v1.ReadRelationshipsResponse) { | ||
| var pages [][]*v1.ReadRelationshipsResponse | ||
| callback := func(_ *cobra.Command, responses []*v1.ReadRelationshipsResponse) error { | ||
| pages = append(pages, responses) | ||
| return nil | ||
| } | ||
| return callback, &pages | ||
| } |
Contributor
There was a problem hiding this comment.
This is both a little awkward and maybe a little cute. The big thing is that it needs to return a pointer to the slice rather than the slice itself in order for the callback to correctly modify it, but then you have to deref it where it's used.
It's not used in that many places so I can inline if desired.
tstirrat15
force-pushed
the
read-rel-cursoring
branch
from
April 29, 2026 15:40
40f7263 to
65d7bce
Compare
tstirrat15
force-pushed
the
read-rel-cursoring
branch
3 times, most recently
from
April 29, 2026 20:50
d3629bd to
e87a374
Compare
tstirrat15
reviewed
Apr 29, 2026
Comment on lines
+335
to
+337
| // If we set an explicit limit or if we find a page smaller than the page limit, | ||
| // we stop. | ||
| if limitSet || relCount < pageSize { |
Contributor
There was a problem hiding this comment.
This logic changed - we stop iterating if we've explicitly set a limit, or else if the relCount is smaller than the limit.
tstirrat15
force-pushed
the
read-rel-cursoring
branch
from
April 29, 2026 21:54
e87a374 to
7e5ad57
Compare
miparnisari
changed the title
miparnisari
reviewed
Apr 30, 2026
miparnisari
previously approved these changes
Apr 30, 2026
tstirrat15
force-pushed
the
read-rel-cursoring
branch
from
April 30, 2026 14:32
90bb2f7 to
53e0cde
Compare
alecmerdler
previously approved these changes
Apr 30, 2026
Co-authored-by: Maria Ines Parnisari <maineparnisari@gmail.com>
tstirrat15
force-pushed
the
read-rel-cursoring
branch
from
April 30, 2026 14:33
53e0cde to
db249ba
Compare
alecmerdler
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--cursorand--show-cursorflags tozed relationship readso users can resume pagination from a prior cursor token and surface the trailing cursor for follow-up calls.