fix(security): run npm ci with --ignore-scripts#450
Open
jcchavezs wants to merge 1 commit into
Open
Conversation
Contributor
|
Hi @jcchavezs, change looks good, thanks. One blocker before merge: the commits show as Unverified. Could you enable commit signing and re-sign: Once they show Verified, I'll approve. Thanks. |
jcchavezs
force-pushed
the
ci_ignore_scripts
branch
6 times, most recently
from
6a94e53 to
9a94f7d
Compare
…ripts Signed-off-by: Jose Carlos Chavez <josecarlos.chavez@owasp.org>
jcchavezs
force-pushed
the
ci_ignore_scripts
branch
from
9a94f7d to
d91fb65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would avoid malicious scripts in vulnerable packages to be executed on CI