Skip to content

fix(sessison): safe usage of localStorage (#519) #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HugoMuller wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(sessison): safe usage of localStorage (#519) #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/runtime/app/composables/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,13 @@ export function useUserSession(): UserSessionComposable {
}
}
const openInPopup = (route: string, size: { width?: number, height?: number } = {}) => {
// Set a local storage item to tell the popup that we pending auth
localStorage.setItem('temp-nuxt-auth-utils-popup', 'true')
try {
// Set a local storage item to tell the popup that we pending auth
localStorage.setItem('temp-nuxt-auth-utils-popup', 'true')
}
catch (error) {
console.error('[nuxt-auth-utils] Could not use localStorage during popup flow initialization.', error)
}

const width = size.width ?? 960
const height = size.height ?? 600
Expand Down
15 changes: 10 additions & 5 deletions src/runtime/app/plugins/session.client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,15 @@ export default defineNuxtPlugin(async (nuxtApp: NuxtApp) => {
})
}

if (localStorage.getItem('temp-nuxt-auth-utils-popup')) {
// There is a local storage item. That's mean we are coming back in the popup
localStorage.removeItem('temp-nuxt-auth-utils-popup')
const error = useError()
if (!error.value) window.close()
try {
if (localStorage.getItem('temp-nuxt-auth-utils-popup')) {
// There is a local storage item. That's mean we are coming back in the popup
localStorage.removeItem('temp-nuxt-auth-utils-popup')
const error = useError()
if (!error.value) window.close()
}
}
catch (error) {
console.error('[nuxt-auth-utils] Could not use localStorage during popup flow last step. Popup won\'t be closed automatically.', error)
}
})