Weaken test to improve flakiness#213
Open
MichaelChirico wants to merge 3 commits into
Open
Conversation
It seems the actual flakiness is higher, and maxeval is always reached (not xtol_rel).
Contributor
|
Maybe drop the tolerance back to 2e-2 again, given that four platforms are failing? |
Author
|
Hmm those errors look unrelated; I reproduce them on |
Contributor
I think those may be the issues with which @astamm is dealing with the nlopt sources themselves. |
Owner
|
Yes. I have a PR under review here: stevengj/nlopt#608. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #212 by reducing flakiness to ~.1%