Skip to content

Fix health check redis host - #322

Open
yoyotop wants to merge 7 commits into
ascherj:mainfrom
yoyotop:fix-health-check-redis-host
Open

Fix health check redis host#322
yoyotop wants to merge 7 commits into
ascherj:mainfrom
yoyotop:fix-health-check-redis-host

Conversation

@yoyotop

@yoyotop yoyotop commented Jul 27, 2026

Copy link
Copy Markdown

Summary

This PR fixes the Redis health check by replacing references to the nonexistent settings.redis_host and settings.redis_port fields with the existing settings.redis_url configuration. This prevents the /health endpoint from raising an AttributeError when checking Redis.

Issue

Closes #155

Changes

  • Replaced redis.Redis(host=..., port=...) with redis.from_url(settings.redis_url)
  • Updated the Redis health check to use the existing application configuration

Testing

  • Unit tests pass (make test-unit)
  • Integration tests pass (make test-integration)
  • Linter passes (make lint)
  • Type checker passes (make typecheck)
  • New/updated tests cover the changes

Manual verification:

  • Verified that GET /health no longer raises an AttributeError and returns a health status response.

Screenshots / Demo

N/A

Notes for Reviewers

Local pre-commit hooks reported existing lint/type-check issues in api/routes/health.py that appear unrelated to this change. The functional change in this PR is limited to using settings.redis_url for the Redis health check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Health check references settings.redis_host, which does not exist on Settings

1 participant