Fix health check redis host - #322
Open
yoyotop wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the Redis health check by replacing references to the nonexistent
settings.redis_hostandsettings.redis_portfields with the existingsettings.redis_urlconfiguration. This prevents the/healthendpoint from raising anAttributeErrorwhen checking Redis.Issue
Closes #155
Changes
redis.Redis(host=..., port=...)withredis.from_url(settings.redis_url)Testing
make test-unit)make test-integration)make lint)make typecheck)Manual verification:
GET /healthno longer raises anAttributeErrorand returns a health status response.Screenshots / Demo
N/A
Notes for Reviewers
Local pre-commit hooks reported existing lint/type-check issues in
api/routes/health.pythat appear unrelated to this change. The functional change in this PR is limited to usingsettings.redis_urlfor the Redis health check.