Fix rug rendering for Bokeh and Plotly backends - #542
Conversation
|
I investigated the failed Read the Docs check. The build completes installation and reaches the gallery, then fails in the existing This is unrelated to the rug-rendering files changed here. The same traceback is present in all three recent RTD builds for PR #540 (builds 33674049, 33674946, and 33675021), which confirms it is a shared docs/dependency failure rather than a regression from this PR. The focused test suite and backend tests listed in the description remain green locally. |
OriolAbril
left a comment
There was a problem hiding this comment.
Thanks for the PR and the note on LLM use and especially for checking things work and do what is expected. If I may even though I don't know what your goals are I would recommend focusing on understanding what the code is doing. I think doing that would probably have gotten you even further in the PR and also been more helpful for any related future task.
For example, you might have fixed the comments on the bokeh and plotly backends directly. We single "|" marker out to help with generating rug plots, but after that bokeh sees marker="dash", why would this marker behave differently than the rest? Similarly, plotly is one of the most popular plotting libraries in python, why would the default behaviour of scatter(data, symbol="line-ns-open") be plotting something that can't be seen?
The readthedocs failure was due to a temporal mismatch between arviz-stats and arviz-plots, once you rebase on main it will be fixed.
4950bca to
09dde35
Compare
|
Rebased onto current Verification after the rebase: 636 passed, 3 skipped across |
Documentation build overview
62 files changed ·
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #542 +/- ##
=======================================
Coverage 88.63% 88.63%
=======================================
Files 64 64
Lines 7266 7268 +2
=======================================
+ Hits 6440 6442 +2
Misses 826 826 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Fixes #535.
Verification
uv run --extra test --extra matplotlib --extra bokeh --extra plotly pytest tests/test_bokeh.py tests/test_plotly.py tests/test_plots.py -q(636 passed, 3 skipped)uvx ruff check src/arviz_plots/backend/bokeh/core.py src/arviz_plots/backend/plotly/core.py src/arviz_plots/visuals/__init__.py tests/test_bokeh.py tests/test_plotly.py tests/test_plots.pyuvx ruff format --check src/arviz_plots/backend/bokeh/core.py src/arviz_plots/backend/plotly/core.py src/arviz_plots/visuals/__init__.py tests/test_bokeh.py tests/test_plotly.py tests/test_plots.pyAI assistance
I used Codex to help inspect the backend-specific marker semantics and draft the tests. I reviewed the implementation, verified the behavior across the Bokeh, Plotly, and backend-neutral paths, and can maintain the submitted changes.