Skip to content

aic8800: add generic D80 SDIO firmware names - #138

Open
sormy wants to merge 1 commit into
armbian:masterfrom
sormy:aic8800-d80-sdio-generic-names
Open

aic8800: add generic D80 SDIO firmware names#138
sormy wants to merge 1 commit into
armbian:masterfrom
sormy:aic8800-d80-sdio-generic-names

Conversation

@sormy

@sormy sormy commented Aug 15, 2026

Copy link
Copy Markdown

The in-tree aic8800_sdio driver opens its firmware by un-suffixed name
(aic8800_bsp/aic_bsp_main.c: .wl_fw = "fmacfw.bin", .bt_table = "fw_patch_table.bin"):

aic8800/SDIO/aic8800D80/{fmacfw,fw_adid,fw_patch,fw_patch_table}.bin

Only the *_8800d80_u02.bin variants are shipped, so Wi-Fi fails to initialise
unless the out-of-tree Radxa DKMS package is used.

This adds four relative symlinks to the existing files. No binaries added or changed.

Tested on an RK3528 TV box: firmware loads, wlan0 associates on both bands.

The in-kernel aic8800_sdio driver builds its firmware paths from
un-suffixed names and opens them directly:

  /lib/firmware/aic8800/SDIO/aic8800D80/fmacfw.bin
  /lib/firmware/aic8800/SDIO/aic8800D80/fw_adid.bin
  /lib/firmware/aic8800/SDIO/aic8800D80/fw_patch.bin
  /lib/firmware/aic8800/SDIO/aic8800D80/fw_patch_table.bin

Only the *_8800d80_u02.bin variants are shipped, so Wi-Fi fails to
initialise on boards using the in-tree driver rather than the
out-of-tree Radxa DKMS. Add symlinks for the four names the driver
actually requests.
@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (4)
  • aic8800/SDIO/aic8800D80/fmacfw.bin is excluded by !**/*.bin
  • aic8800/SDIO/aic8800D80/fw_adid.bin is excluded by !**/*.bin
  • aic8800/SDIO/aic8800D80/fw_patch.bin is excluded by !**/*.bin
  • aic8800/SDIO/aic8800D80/fw_patch_table.bin is excluded by !**/*.bin

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b91cc508-72a7-4be3-be63-5eabe7cef7ca

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant