Skip to content

fix: allow prototype method names as object keys #1586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kaigritun wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: allow prototype method names as object keys #1586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ark/schema/structure/structure.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ const implementation: nodeImplementationOf<Structure.Declaration> =
reduce: (inner, $) => {
if (!inner.required && !inner.optional) return

const seen: Record<Key, true | undefined> = {}
const seen: Record<Key, true | undefined> = Object.create(null)
let updated = false
const newOptionalProps: OptionalNode[] =
inner.optional ? [...inner.optional] : []
Expand Down
16 changes: 16 additions & 0 deletions ark/type/__tests__/objects/props.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,4 +94,20 @@ contextualize(() => {
})
).throws(writeDuplicateKeyMessage("a"))
})

it("allows prototype method names as keys", () => {
// constructor, hasOwnProperty, toString, etc. are valid object keys
// and should not be incorrectly flagged as duplicates
const T = type({
constructor: "string",
hasOwnProperty: "number",
toString: "boolean"
})

attest<{
constructor: string
hasOwnProperty: number
toString: boolean
}>(T.t)
})
})