Skip to content

Make reviewdog fail_on_error configurable #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sksat (sksat) wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Make reviewdog fail_on_error configurable #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f56e6f4
make reviewdog fail_on_error configurable
sksat Feb 8, 2024
b554b78
disable fail_on_error in test-build workflow to avoid error from old …
sksat Feb 8, 2024
e976839
TEMP
sksat Feb 8, 2024
e48c54f
test with github-pr-review reporter
sksat Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,15 @@ on:
reviewdog_default_filter:
type: string
default: added
reviewdog_fail_on_error:
type: boolean
default: true
secrets:
GH_FEDERATION_ENDPOINT:
required: false

env:
SELF_VERSION: v5.4.0
SELF_VERSION: make-reviewdog-fail-on-error-configurable

jobs:
build_linux32:
Expand Down Expand Up @@ -100,6 +103,7 @@ jobs:
reviewdog_tool_name: clang-tidy -${{ matrix.warning }}
reviewdog_reporter: ${{ (!contains(matrix.warning, 'Wextra') && inputs.reviewdog_default_reporter ) || 'github-check' }}
reviewdog_filter_mode: ${{ (!contains(matrix.warning, 'Wextra') && inputs.reviewdog_default_filter ) || 'nofilter' }}
reviewdog_fail_on_error: ${{ inputs.reviewdog_fail_on_error }}

build_linux32_cxx:
if: inputs.build_as_cxx
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/test-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,6 @@ jobs:
cmake_flags_linux32: -DUSE_SCI_COM_WINGS=OFF -DC2A_USE_SCI_COM_WINGS=OFF
sils_mockup: true
build_as_cxx: true
reviewdog_default_reporter: github-check
reviewdog_default_reporter: github-pr-review
reviewdog_default_filter: added
reviewdog_fail_on_error: false
Comment thread
sksat marked this conversation as resolved.
4 changes: 4 additions & 0 deletions action-c2a-build/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ inputs:
reviewdog_filter_mode:
type: string
default: added
reviewdog_fail_on_error:
type: boolean
default: true

runs:
using: "composite"
Expand Down Expand Up @@ -125,3 +128,4 @@ runs:
reporter: ${{ inputs.reviewdog_reporter }}
filter_mode: ${{ inputs.reviewdog_filter_mode }}
workdir: ./c2a_user/${{ inputs.c2a_dir }}/build
fail_on_error: ${{ inputs.reviewdog_fail_on_error }}