Skip to content

fix a panic causing a crash when clangd sends workspaceSemanticTokensRefresh#232

Open
santtuniskanen wants to merge 4 commits into
arduino:mainfrom
santtuniskanen:implement/WorkspaceSemantictokensRefresh
Open

fix a panic causing a crash when clangd sends workspaceSemanticTokensRefresh#232
santtuniskanen wants to merge 4 commits into
arduino:mainfrom
santtuniskanen:implement/WorkspaceSemantictokensRefresh

Conversation

@santtuniskanen

Copy link
Copy Markdown

Please check if the PR fulfills these requirements

  • What kind of change does this PR introduce?
    adds a client handler for workspace/semanticTokens/refresh in lsp_client_clangd.go.
  • What is the current behavior?
    When clangd sends workspace/semanticTokens/refresh, it causes a panic. This causes the language server to crash on every restart. A workaround has been to disable semantic tokens in your editor, but this fix should prevent the need to do so.

21:11:04.196586 IDE LS <-- Clangd REQU workspace/semanticTokens/refresh 1
21:11:04.196684 Panic: unimplemented request: workspace/semanticTokens/refresh

  • What is the new behavior?
    refresh request comes in and goes out, without causing a panic and crashing the language server.

21:19:11.867890 IDE LS <-- Clangd REQU workspace/semanticTokens/refresh 1
21:19:11.867912 IDE LS --> Clangd RESP workspace/semanticTokens/refresh 1

  • Other information:
    depends on bugst/go-lsp#10 to be approved and merged first. The module version should then be bumped up before merge.

Fixes #125 Fixes #155

@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Mar 25, 2026
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Santtu Niskanen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@per1234 per1234 added the status: blocked Progress on this prevented by an external cause label Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: blocked Progress on this prevented by an external cause topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Projects

None yet

3 participants