test(k8s): add vuln-only and secret-only cases to Test_separateMisconfigReports - #11041
Open
no-hup wants to merge 1 commit into
Open
test(k8s): add vuln-only and secret-only cases to Test_separateMisconfigReports#11041no-hup wants to merge 1 commit into
no-hup wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test_separateMisconfigReportshas carried two TODOs for a while:This adds both cases, reusing the existing
deployOrionWithVulns,cronjobHelloWithVulnsanddeployLuaWithSecretsfixtures from the same file. Each case runsSeparateMisconfigReportswith only the vulnerability (resp. secret) scanner enabled and pins the current routing: the workload assessment carries the resources, and the infra assessment is still emitted (empty) becauseshouldAddToReportincludes both scanners. Test-only change, no behavior touched.No linked issue: test-only addition answering an in-code TODO, per the trivial-change allowance in the contributing docs.
Checklist