Skip to content

dark mode fixes #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raphschwander merged 1 commit into from
Oct 23, 2025
Merged

dark mode fixes #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Updraft/Feedback/View/Description/FeedbackDescriptionViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,10 +211,10 @@ extension FeedbackDescriptionViewController: UIPickerViewDataSource {

extension FeedbackDescriptionViewController: UIPickerViewDelegate {

func pickerView(_ pickerView: UIPickerView, titleForRow row: Int, forComponent component: Int) -> String? {
let title = tags[row]?.localized ?? ""
return title
}
func pickerView(_ pickerView: UIPickerView, attributedTitleForRow row: Int, forComponent component: Int) -> NSAttributedString? {
let title = tags[row]?.localized ?? ""
return NSAttributedString(string: title, attributes: [NSAttributedString.Key.foregroundColor: UIColor.black])
}

func pickerView(_ pickerView: UIPickerView, didSelectRow row: Int, inComponent component: Int) {
guard let tag = tags[row] else { return }
Expand Down
21 changes: 11 additions & 10 deletions Updraft/Feedback/View/Description/FeedbackDescriptionViewController.xib
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?xml version="1.0" encoding="UTF-8"?>
<document type="com.apple.InterfaceBuilder3.CocoaTouch.XIB" version="3.0" toolsVersion="17156" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" useSafeAreas="YES" colorMatched="YES">
<document type="com.apple.InterfaceBuilder3.CocoaTouch.XIB" version="3.0" toolsVersion="24128" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" useSafeAreas="YES" colorMatched="YES">
<device id="retina5_9" orientation="portrait" appearance="light"/>
<dependencies>
<deployment identifier="iOS"/>
<plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="17125"/>
<plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="24063"/>
<capability name="Safe area layout guides" minToolsVersion="9.0"/>
<capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/>
</dependencies>
Expand Down Expand Up @@ -31,26 +31,27 @@
<autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
<subviews>
<textField opaque="NO" contentMode="scaleToFill" contentHorizontalAlignment="left" contentVerticalAlignment="center" placeholder="Email" textAlignment="natural" minimumFontSize="17" translatesAutoresizingMaskIntoConstraints="NO" id="cfC-Jp-oVS" customClass="FeedbackEmailTextField" customModule="Updraft">
<rect key="frame" x="16" y="435" width="343" height="50"/>
<rect key="frame" x="16" y="491" width="343" height="50"/>
<color key="backgroundColor" white="1" alpha="1" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
<constraints>
<constraint firstAttribute="height" constant="50" id="Ytm-LG-yz5"/>
</constraints>
<color key="textColor" white="0.0" alpha="1" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
<fontDescription key="fontDescription" type="system" pointSize="14"/>
<textInputTraits key="textInputTraits"/>
<connections>
<action selector="emailChanged:" destination="-1" eventType="editingChanged" id="tuy-X9-n2p"/>
</connections>
</textField>
<button opaque="NO" contentMode="scaleToFill" contentHorizontalAlignment="center" contentVerticalAlignment="center" buttonType="system" lineBreakMode="middleTruncation" translatesAutoresizingMaskIntoConstraints="NO" id="S7z-1R-HMv" customClass="NavigationButton" customModule="Updraft">
<rect key="frame" x="16" y="529" width="59" height="30"/>
<rect key="frame" x="16" y="585" width="59" height="30"/>
<state key="normal" title="previous"/>
<connections>
<action selector="showPrevious:" destination="-1" eventType="touchUpInside" id="nql-zb-kk0"/>
</connections>
</button>
<button opaque="NO" contentMode="scaleToFill" contentHorizontalAlignment="center" contentVerticalAlignment="center" buttonType="system" lineBreakMode="middleTruncation" translatesAutoresizingMaskIntoConstraints="NO" id="4FE-HS-ZvP" customClass="ActionButton" customModule="Updraft">
<rect key="frame" x="187" y="515" width="172" height="44"/>
<rect key="frame" x="187" y="571" width="172" height="44"/>
<constraints>
<constraint firstAttribute="width" constant="172" id="I2r-5V-zGp"/>
<constraint firstAttribute="height" constant="44" id="aza-5T-NEZ"/>
Expand All @@ -61,15 +62,15 @@
</connections>
</button>
<view contentMode="scaleToFill" translatesAutoresizingMaskIntoConstraints="NO" id="gEX-wn-hc9">
<rect key="frame" x="16" y="74" width="343" height="50"/>
<rect key="frame" x="16" y="130" width="343" height="50"/>
<subviews>
<button opaque="NO" contentMode="scaleToFill" contentHorizontalAlignment="center" contentVerticalAlignment="center" lineBreakMode="middleTruncation" translatesAutoresizingMaskIntoConstraints="NO" id="jmA-ej-aC4">
<rect key="frame" x="305" y="8" width="30" height="34"/>
</button>
<label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" text="Label" textAlignment="natural" lineBreakMode="tailTruncation" baselineAdjustment="alignBaselines" adjustsFontSizeToFit="NO" translatesAutoresizingMaskIntoConstraints="NO" id="aZh-RS-C9b">
<rect key="frame" x="8" y="14.666666666666671" width="42" height="21"/>
<rect key="frame" x="8" y="14.666666666666657" width="42" height="21"/>
<fontDescription key="fontDescription" type="system" pointSize="17"/>
<nil key="textColor"/>
<color key="textColor" white="0.0" alpha="1" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
<nil key="highlightedColor"/>
</label>
</subviews>
Expand All @@ -83,14 +84,14 @@
</constraints>
</view>
<view contentMode="scaleToFill" translatesAutoresizingMaskIntoConstraints="NO" id="BP9-Qb-BS1" customClass="FeedbackDescriptionTextView" customModule="Updraft">
<rect key="frame" x="16" y="305" width="343" height="100"/>
<rect key="frame" x="16" y="361" width="343" height="100"/>
<color key="backgroundColor" white="1" alpha="1" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
<constraints>
<constraint firstAttribute="height" constant="100" id="chL-Uf-4rc"/>
</constraints>
</view>
<view contentMode="scaleToFill" translatesAutoresizingMaskIntoConstraints="NO" id="QBD-9j-ba1">
<rect key="frame" x="16" y="125" width="343" height="150"/>
<rect key="frame" x="16" y="181" width="343" height="150"/>
<subviews>
<pickerView contentMode="scaleToFill" translatesAutoresizingMaskIntoConstraints="NO" id="Ikz-1L-Q7d">
<rect key="frame" x="0.0" y="0.0" width="343" height="150"/>
Expand Down
Loading