+tracing Instrument Invocation handlers using swift-distributed-tracing - #1085
Open
ktoso wants to merge 4 commits into
Open
+tracing Instrument Invocation handlers using swift-distributed-tracing#1085ktoso wants to merge 4 commits into
ktoso wants to merge 4 commits into
Conversation
+tracing injector/extractor for tracing and InvocationMessage
yim-lee
approved these changes
Nov 7, 2022
| import NIO | ||
| import OpenTelemetry | ||
| import OtlpGRPCSpanExporting | ||
| import Tracing |
Contributor
There was a problem hiding this comment.
Are all these imports needed?
| init(actorSystem: ActorSystem) async { | ||
| self.actorSystem = actorSystem | ||
|
|
||
| self.receptionID = "*" // default key for "all of this type" |
Contributor
There was a problem hiding this comment.
Is this the only type that gets registered with the receptionist so it doesn't matter what receptionID is?
Member
Author
There was a problem hiding this comment.
* is by convention the "default key" which we use for "all the actors" #1084
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| import _PrettyLogHandler |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fully functional, basic, swift-distributed-tracing integration... in just 20 lines of actual changed code (!):
80dd5a5(#1085)Further, this includes a complete sample app that illustrates this.
Resolves #847 Instrument system with Swift Distributed Tracing
Resolves #476 Context propagation mechanism for actors: Baggage
The
Samplesproject contains a full sample that showcases this end-to-end. I'll write some docs for it later, but also intend to include this sample in tracing documentation perhaps?Short version:
We automatically get spans for distributed calls etc 🥳
and