Add unit tests for PasswordRulesParser.js#1112
Open
Muneerali199 wants to merge 1 commit into
Open
Conversation
Adds 65 unit tests covering: - Empty/whitespace input - Single and multiple required/allowed rules - max-consecutive, minlength, maxlength - Custom character classes (including dash/bracket edge cases) - Unicode handling (non-ASCII characters dropped) - Canonicalization (full alphabet → named class) - Invalid/malformed inputs (expected errors) - Real-world rule patterns The test suite was adapted from the maintainer's Ruby test suite (shared in issue apple#98) and runs via Node.js with zero dependencies. Includes a new CI job in lint.yml to run tests on every push/PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 65 unit tests for
tools/PasswordRulesParser.js, closing #98.The test cases were adapted from the maintainer's Ruby test suite (shared in issue #98) and expanded with additional edge cases covering custom character classes, canonicalization, unicode handling, and invalid inputs.
Changes
tools/PasswordRulesParser.test.js: 65 unit tests covering:-) and right-bracket (]) edge cases.github/workflows/lint.yml: Newparser-unit-testsCI job that runs the test suite on every push/PRVerification