Skip to content

test: add JSON marshal/unmarshal round-trip tests for Version in fdbkubernetesmonitor api #13048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ronitsabhaya75 wants to merge 4 commits into
base: main
Choose a base branch
from
+21 −0
Open

test: add JSON marshal/unmarshal round-trip tests for Version in fdbkubernetesmonitor api #13048

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17782f8
test: add JSON marshal/unmarshal round-trip tests for Version in fdbk…
Ronitsabhaya75 Apr 21, 2026
60b939f
Potential fix for pull request finding
Ronitsabhaya75 May 9, 2026
d27c309
Merge branch 'main' into test-json-marshal
Ronitsabhaya75 May 9, 2026
99eaa67
Potential fix for pull request finding
Ronitsabhaya75 May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions fdbkubernetesmonitor/api/version_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,27 @@ import (
)

var _ = Describe("[api] FDBVersion", func() {
When("marshaling and unmarshaling a Version as JSON", func() {
It("should round-trip a stable version", func() {
original := Version{Major: 7, Minor: 3, Patch: 27}
Comment thread
Ronitsabhaya75 marked this conversation as resolved.
data, err := json.Marshal(&original)
Expect(err).NotTo(HaveOccurred())
Expect(string(data)).To(Equal(`"7.3.27"`))

var decoded Version
Expect(json.Unmarshal(data, &decoded)).To(Succeed())
Expect(decoded).To(Equal(original))
})

It("should return an error when unmarshaling invalid version strings", func() {
for _, invalidVersion := range []string{`"not-a-version"`, `"7.3"`} {
var decoded Version
err := json.Unmarshal([]byte(invalidVersion), &decoded)
Expect(err).To(HaveOccurred())
}
})
})

When("checking if the protocol and the version are compatible", func() {
It("should return the correct compatibility", func() {
version := Version{Major: 6, Minor: 2, Patch: 20}
Expand Down