fix: invert addWatcher error check and prevent HTTP/TLS server fallthrough in fdbkubernetesmonitor#13045
Open
Ronitsabhaya75 wants to merge 1 commit intoapple:mainfrom
Open
fix: invert addWatcher error check and prevent HTTP/TLS server fallthrough in fdbkubernetesmonitor#13045Ronitsabhaya75 wants to merge 1 commit intoapple:mainfrom
Ronitsabhaya75 wants to merge 1 commit intoapple:mainfrom
Conversation
…rough in fdbkubernetesmonitor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addWatcher returned nil on error and retried on success due to err != nil instead of err == nil. This caused file-watch re-establishment to silently fail after ConfigMap remounts, permanently stopping config change detection.
When TLS is configured, the goroutine falls through from the HTTPS block to also start a plain HTTP server on the same port. Added return after the HTTPS block to make the HTTPS-or-HTTP intent explicit.
Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branchormainif this is the youngest branch)